Skip to content

Restructure connection logic #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Jul 23, 2020
Merged

Restructure connection logic #176

merged 15 commits into from
Jul 23, 2020

Conversation

aentinger
Copy link
Contributor

... by rewriting into an integrated state machine making all necessary steps visible instead of hidden.

@aentinger aentinger added the type: enhancement Proposed improvement label Jul 23, 2020
@aentinger aentinger self-assigned this Jul 23, 2020
@codecov-commenter
Copy link

codecov-commenter commented Jul 23, 2020 •
edited
Loading

Codecov Report

Merging #176 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #176   +/-   ##
=======================================
  Coverage   95.61%   95.61%           
=======================================
  Files          29       29           
  Lines        1004     1004           
=======================================
  Hits          960      960           
  Misses         44       44

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b6a1257...b673b59. Read the comment docs.

@arduino-libraries arduino-libraries deleted a comment from github-actions bot Jul 23, 2020
@github-actions
Copy link

Memory usage change @ 41700b1

Board flash RAM for global variables
arduino:samd:mkr1000 💚 -352 - -336 0 - 0
arduino:samd:mkrgsm1400 💚 -1056 - -856 💚 -8 - -8
arduino:samd:mkrwan1300 0 - 0 0 - 0
arduino:samd:mkrwifi1010 💚 -1056 - -848 💚 -8 - -8
arduino:samd:nano_33_iot 💚 -1048 - -848 💚 -8 - -8
esp8266:esp8266:huzzah 💚 -52 - -36 🔺 +20 - +32
Click for full report table
Board examples/ArduinoIoTCloud-Advanced
flash		 examples/ArduinoIoTCloud-Advanced
RAM for global variables		 examples/ArduinoIoTCloud-Basic
flash		 examples/ArduinoIoTCloud-Basic
RAM for global variables		 examples/utility/ArduinoIoTCloud_Travis_CI
flash		 examples/utility/ArduinoIoTCloud_Travis_CI
RAM for global variables		 examples/utility/Provisioning
flash		 examples/utility/Provisioning
RAM for global variables
arduino:samd:mkr1000 -344 0 -352 0 -344 0 -336 0
arduino:samd:mkrgsm1400 -1056 -8 -1056 -8 -1056 -8 -856 -8
arduino:samd:mkrwan1300 0 0 0 0 0 0
arduino:samd:mkrwifi1010 -1056 -8 -1048 -8 -1056 -8 -848 -8
arduino:samd:nano_33_iot -1048 -8 -1048 -8 -1048 -8 -848 -8
esp8266:esp8266:huzzah -52 32 -48 20 -36 32
Click for full report CSV 
Board,examples/ArduinoIoTCloud-Advanced<br>flash,examples/ArduinoIoTCloud-Advanced<br>RAM for global variables,examples/ArduinoIoTCloud-Basic<br>flash,examples/ArduinoIoTCloud-Basic<br>RAM for global variables,examples/utility/ArduinoIoTCloud_Travis_CI<br>flash,examples/utility/ArduinoIoTCloud_Travis_CI<br>RAM for global variables,examples/utility/Provisioning<br>flash,examples/utility/Provisioning<br>RAM for global variables
arduino:samd:mkr1000,-344,0,-352,0,-344,0,-336,0
arduino:samd:mkrgsm1400,-1056,-8,-1056,-8,-1056,-8,-856,-8
arduino:samd:mkrwan1300,0,0,0,0,0,0,,
arduino:samd:mkrwifi1010,-1056,-8,-1048,-8,-1056,-8,-848,-8
arduino:samd:nano_33_iot,-1048,-8,-1048,-8,-1048,-8,-848,-8
esp8266:esp8266:huzzah,-52,32,-48,20,-36,32,,

@arduino-libraries arduino-libraries deleted a comment from github-actions bot Jul 23, 2020
@github-actions
Copy link

Memory usage change @ b673b59

Board flash RAM for global variables
arduino:samd:mkr1000 💚 -368 - -360 0 - 0
arduino:samd:mkrgsm1400 💚 -1072 - -872 💚 -8 - -8
arduino:samd:mkrnb1500 💚 -368 - -360 0 - 0
arduino:samd:mkrwan1300 🔺 +7128 - +7136 🔺 +160 - +176
arduino:samd:mkrwifi1010 💚 -1064 - -864 💚 -8 - -8
arduino:samd:nano_33_iot 💚 -1064 - -864 💚 -8 - -8
esp8266:esp8266:huzzah 💚 -364 - -344 💚 -264 - -252
Click for full report table
Board examples/ArduinoIoTCloud-Advanced
flash		 examples/ArduinoIoTCloud-Advanced
RAM for global variables		 examples/ArduinoIoTCloud-Basic
flash		 examples/ArduinoIoTCloud-Basic
RAM for global variables		 examples/utility/ArduinoIoTCloud_Travis_CI
flash		 examples/utility/ArduinoIoTCloud_Travis_CI
RAM for global variables		 examples/utility/Provisioning
flash		 examples/utility/Provisioning
RAM for global variables
arduino:samd:mkr1000 -368 0 -368 0 -368 0 -360 0
arduino:samd:mkrgsm1400 -1064 -8 -1064 -8 -1072 -8 -872 -8
arduino:samd:mkrnb1500 -368 0 -368 0 -368 0 -360 0
arduino:samd:mkrwan1300 7128 164 7128 160 7136 176
arduino:samd:mkrwifi1010 -1064 -8 -1064 -8 -1064 -8 -864 -8
arduino:samd:nano_33_iot -1064 -8 -1064 -8 -1064 -8 -864 -8
esp8266:esp8266:huzzah -364 -264 -344 -252 -348 -256
Click for full report CSV 
Board,examples/ArduinoIoTCloud-Advanced<br>flash,examples/ArduinoIoTCloud-Advanced<br>RAM for global variables,examples/ArduinoIoTCloud-Basic<br>flash,examples/ArduinoIoTCloud-Basic<br>RAM for global variables,examples/utility/ArduinoIoTCloud_Travis_CI<br>flash,examples/utility/ArduinoIoTCloud_Travis_CI<br>RAM for global variables,examples/utility/Provisioning<br>flash,examples/utility/Provisioning<br>RAM for global variables
arduino:samd:mkr1000,-368,0,-368,0,-368,0,-360,0
arduino:samd:mkrgsm1400,-1064,-8,-1064,-8,-1072,-8,-872,-8
arduino:samd:mkrnb1500,-368,0,-368,0,-368,0,-360,0
arduino:samd:mkrwan1300,7128,164,7128,160,7136,176,,
arduino:samd:mkrwifi1010,-1064,-8,-1064,-8,-1064,-8,-864,-8
arduino:samd:nano_33_iot,-1064,-8,-1064,-8,-1064,-8,-864,-8
esp8266:esp8266:huzzah,-364,-264,-344,-252,-348,-256,,

@aentinger
Copy link
Contributor Author

Successfully on PROD tested with

  • MKR WiFi 1010 ✔️
  • Nano 33 IoT ✔️
  • MKR 1000 ✔️
  • ESP 8266 ✔️
  • MKR GSM 1400 ✔️

@aentinger aentinger merged commit c16298c into master Jul 23, 2020
@aentinger aentinger deleted the restructure-connection-logic branch July 23, 2020 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@aentinger aentinger

Labels
type: enhancement Proposed improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aentinger @codecov-commenter